[
https://issues.apache.org/jira/browse/HDFS-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186513#comment-15186513
]
Anu Engineer commented on HDFS-9702:
------------------------------------
Hi [~eddyxu],
Thanks for the feedback and pointing to me to GenericTestUtils. IMHO, in this
specific case I think the current code is a bit cleaner than using
{{GenericTestUtils#assertExceptionContains}}
I will have to add (please let me know if I am mistaken)
{code}
try { …. } catch(DiskBalancerException ex) {
GenericTestUtils.assertExceptionContains("a Rule", ex)) }
{code}
in each test. Whereas the current code does the same thing with a single line
and uses established patterns from *Junit*.
{code}
thrown.expect(new ResultVerifier(Result.NO_SUCH_PLAN));
{code}
So if it is a matter of taste, I would prefer to keep the current code. If you
see any correctness issue please let me know and I would love to fix it.
> DiskBalancer : getVolumeMap implementation
> ------------------------------------------
>
> Key: HDFS-9702
> URL: https://issues.apache.org/jira/browse/HDFS-9702
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-1312
>
> Attachments: HDFS-9702-HDFS-1312.001.patch,
> HDFS-9702-HDFS-1312.002.patch
>
>
> Add get volume map
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
