[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185555#comment-15185555
]
Jing Zhao commented on HDFS-7866:
---------------------------------
The patch also LGTM. Thanks for the great work, [~lirui].
My only comment is about the change in hdfs.proto:
{code}
340 required uint32 id = 4; // Actually a byte - only 8 bits used
{code}
Although EC has not been officially released yet, some ppl may already adopt it
in test/production cluster considering the feature has been in 3.0 for a while.
Adding a required field is an incompatible change for them. Thus it's better to
use optional here.
And if I understand the above discussion correctly, we will address the
INodeFile constructor (and the toLong method) in a follow-on jira, right?
> Erasure coding: NameNode manages multiple erasure coding policies
> -----------------------------------------------------------------
>
> Key: HDFS-7866
> URL: https://issues.apache.org/jira/browse/HDFS-7866
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Rui Li
> Attachments: HDFS-7866-v1.patch, HDFS-7866-v2.patch,
> HDFS-7866-v3.patch, HDFS-7866.10.patch, HDFS-7866.11.patch,
> HDFS-7866.12.patch, HDFS-7866.13.patch, HDFS-7866.4.patch, HDFS-7866.5.patch,
> HDFS-7866.6.patch, HDFS-7866.7.patch, HDFS-7866.8.patch, HDFS-7866.9.patch
>
>
> This is to extend NameNode to load, list and sync predefine EC schemas in
> authorized and controlled approach. The provided facilities will be used to
> implement DFSAdmin commands so admin can list available EC schemas, then
> could choose some of them for target EC zones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
