[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185855#comment-15185855
]
Zhe Zhang commented on HDFS-7866:
---------------------------------
Thanks Jing for the review. Changing the proto field to optional is a valid
concern. However, from a schema point of view, having the ID as optional looks
a little weird -- it should be the "primary key" of the policy in the table.
When receiving a policy proto, it's helpful to verify it with the policy table
for diagnosis. It's also a little awkward to have {{BlockStoragePolicy#id}} as
required but EC policy ID as optional. I think the pre-release incompatibility
is probably worth it. But LMK if you agree.
bq. And if I understand the above discussion correctly, we will address the
INodeFile constructor (and the toLong method) in a follow-on jira, right?
Yes that's the plan. Actually I plan to work on the cleanup JIRA.
> Erasure coding: NameNode manages multiple erasure coding policies
> -----------------------------------------------------------------
>
> Key: HDFS-7866
> URL: https://issues.apache.org/jira/browse/HDFS-7866
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Rui Li
> Attachments: HDFS-7866-v1.patch, HDFS-7866-v2.patch,
> HDFS-7866-v3.patch, HDFS-7866.10.patch, HDFS-7866.11.patch,
> HDFS-7866.12.patch, HDFS-7866.13.patch, HDFS-7866.4.patch, HDFS-7866.5.patch,
> HDFS-7866.6.patch, HDFS-7866.7.patch, HDFS-7866.8.patch, HDFS-7866.9.patch
>
>
> This is to extend NameNode to load, list and sync predefine EC schemas in
> authorized and controlled approach. The provided facilities will be used to
> implement DFSAdmin commands so admin can list available EC schemas, then
> could choose some of them for target EC zones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
