[
https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189964#comment-15189964
]
Xiao Chen commented on HDFS-9405:
---------------------------------
Thanks Arun and Mingliang for the review.
Mingliang's comments #0 and #1 are reflected in patch 4.
bq. 2. In the unit test method, is the second spy() needed?
Yes, since [Mockito
implementation|http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b27/java/lang/Class.java#2619]
copies the field.
> When starting a file, NameNode should generate EDEK in a separate thread
> ------------------------------------------------------------------------
>
> Key: HDFS-9405
> URL: https://issues.apache.org/jira/browse/HDFS-9405
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption, namenode
> Affects Versions: 2.7.1
> Reporter: Zhe Zhang
> Assignee: Xiao Chen
> Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch,
> HDFS-9405.03.patch, HDFS-9405.04.patch
>
>
> {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation
> to the key provider, which could be slow or cause timeout. It should be done
> as a separate thread so as to return a proper error message to the RPC caller.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
