[ https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190271#comment-15190271 ]
Mingliang Liu commented on HDFS-9405: ------------------------------------- Thanks for updating the patch, [~xiaochen]. I was aware that we need to define variable {{spy}} again before the last assertion. My concern was that we don't need to call {{spy()}} method against the real object as we're not operating/mocking it. Even I'm right I have to admit it's minor. > When starting a file, NameNode should generate EDEK in a separate thread > ------------------------------------------------------------------------ > > Key: HDFS-9405 > URL: https://issues.apache.org/jira/browse/HDFS-9405 > Project: Hadoop HDFS > Issue Type: Improvement > Components: encryption, namenode > Affects Versions: 2.7.1 > Reporter: Zhe Zhang > Assignee: Xiao Chen > Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch, > HDFS-9405.03.patch, HDFS-9405.04.patch > > > {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation > to the key provider, which could be slow or cause timeout. It should be done > as a separate thread so as to return a proper error message to the RPC caller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)