[ 
https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198262#comment-15198262
 ] 

Andrew Wang commented on HDFS-9405:
-----------------------------------

Based on my read of the [interrupt 
docs|https://docs.oracle.com/javase/7/docs/api/java/lang/Thread.html#interrupt()],
 the idea is that we just need something in the while loop that handles the 
interrupt so we can exit in a timely fashion. Both {{sleep}} and manually 
checking the interrupt status achieves this. The biggest block of code where an 
interrupt could come in is {{warmUpEncryptedKeys}}, and the call to {{sleep}} 
right afterwards means we'll exit relatively promptly.

> When starting a file, NameNode should generate EDEK in a separate thread
> ------------------------------------------------------------------------
>
>                 Key: HDFS-9405
>                 URL: https://issues.apache.org/jira/browse/HDFS-9405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: encryption, namenode
>    Affects Versions: 2.7.1
>            Reporter: Zhe Zhang
>            Assignee: Xiao Chen
>         Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch, 
> HDFS-9405.03.patch, HDFS-9405.04.patch, HDFS-9405.05.patch, 
> HDFS-9405.06.patch, HDFS-9405.07.patch, HDFS-9405.08.patch
>
>
> {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation 
> to the key provider, which could be slow or cause timeout. It should be done 
> as a separate thread so as to return a proper error message to the RPC caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to