[
https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198161#comment-15198161
]
Xiao Chen commented on HDFS-9405:
---------------------------------
Thanks Andrew. Will address the comments, except:
bq. Do we need this check? The sleep right before it will throw
InterruptedException and clear the interrupted status.
The reason for this is to handle {{shutdownNow}} - in which case the runnable
will be interrupted. If we happen to be not in {{Thread.sleep}} block, we
should exit. right?
bq. It looks like we're trying to ride out KMS downtime, so is there a downside
to retrying indefinitely?
I think retrying definitely would be the KISS solution. I feel configuration
won't help much for most users.
Retry interval maybe good to be configurable.
Will change into this manner if no objections.
> When starting a file, NameNode should generate EDEK in a separate thread
> ------------------------------------------------------------------------
>
> Key: HDFS-9405
> URL: https://issues.apache.org/jira/browse/HDFS-9405
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption, namenode
> Affects Versions: 2.7.1
> Reporter: Zhe Zhang
> Assignee: Xiao Chen
> Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch,
> HDFS-9405.03.patch, HDFS-9405.04.patch, HDFS-9405.05.patch,
> HDFS-9405.06.patch, HDFS-9405.07.patch, HDFS-9405.08.patch
>
>
> {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation
> to the key provider, which could be slow or cause timeout. It should be done
> as a separate thread so as to return a proper error message to the RPC caller.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
