[
https://issues.apache.org/jira/browse/HDFS-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205769#comment-15205769
]
Rakesh R commented on HDFS-7648:
--------------------------------
Thanks [~szetszwo] for the reply.
bq. Why it needs a separated sub-task but not just updating the patch here?
bq. The two chunks of code above are duplicated. Please add a helper method to
avoid the duplication. Thanks.
The attached patches in this jira is quite old. Please ignore these patches as
the propsed changes has been implemented using HDFS-7819. I have raised this
sub-task based on the
[discussion|https://issues.apache.org/jira/browse/HDFS-7648?focusedCommentId=14332305&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14332305].
Also, please refer
[DirectoryScanner.java#L916|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java#L916]
to see the code changes. Initially the discussion was to identify the wrong
items and automatically fixing it, but couldn't reach to a conclusion. Since we
haven't fully implemented the original idea of fixing the wrong blocks I
thought of keeping this jira open(one can refer this jira comments to get the
background) and fix smaller parts separately through sub-tasks.
Should I delete the attached old patches from this jira to avoid confusions if
any?
> Verify that HDFS blocks are in the correct datanode directories
> ---------------------------------------------------------------
>
> Key: HDFS-7648
> URL: https://issues.apache.org/jira/browse/HDFS-7648
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Rakesh R
> Attachments: HDFS-7648-3.patch, HDFS-7648-4.patch, HDFS-7648-5.patch,
> HDFS-7648.patch, HDFS-7648.patch
>
>
> HDFS-6482 changed datanode layout to use block ID to determine the directory
> to store the block. We should have some mechanism to verify it. Either
> DirectoryScanner or block report generation could do the check.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
