[
https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210509#comment-15210509
]
Arpit Agarwal commented on HDFS-9847:
-------------------------------------
bq. This is the WARN for missing units? It should warn, shouldn't it? The calls
specifying TimeUnit.SECONDS are for backwards compatibility, and would
otherwise be in millis. The changes to hdfs-default.xml should include units
(changing their type) in this release, then we can change the caller after
users have been warned for using values without units.
Okay. it will be confusing for administrators to start seeing these warnings
post-upgrade if they are not relying on the defaults in {{hdfs-default.xml}}.
Not sure what is the right thing to do here, if you feel the warning is
warranted then let's keep it.
> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
> Key: HDFS-9847
> URL: https://issues.apache.org/jira/browse/HDFS-9847
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Attachments: HDFS-9847-nothrow.001.patch, HDFS-9847.001.patch,
> HDFS-9847.002.patch, HDFS-9847.003.patch, HDFS-9847.004.patch,
> HDFS-9847.005.patch, HDFS-9847.006.patch, timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly
> units e.g. 60s, 5m, 1d, 6w etc. But there are som configuration key names
> contain time unit name, like {{dfs.blockreport.intervalMsec}}, so we can make
> some other configurations which without time unit name to accept friendly
> time units. The time unit {{seconds}} is frequently used in hdfs. We can
> updating this configurations first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
