[jira] [Commented] (HDFS-8356) Document missing properties in hdfs-default.xml

[Akira AJISAKA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221250#comment-15221250
 ] 

Akira AJISAKA commented on HDFS-8356:
-------------------------------------

Thanks [~rchiang] for the update. Review comments for TestHdfsConfigFields.java:

{code}
    // Remove new property for now
    xmlPropsToSkipCompare.add("dfs.client.hedged.threadpool.size");
{code}
1. Would you remove the above code because HDFS-9886 has been fixed?

{code}
    // Remove support property
    xmlPropsToSkipCompare
        .add(DFSConfigKeys.DFS_NAMENODE_MIN_SUPPORTED_DATANODE_VERSION_KEY);
    xmlPropsToSkipCompare
        .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY);
{code}
2. I'm thinking we can remove the above because the parameters don't exist in 
hdfs-default.xml.

{code}
    configurationPropsToSkipCompare
        .add(DFSConfigKeys.DFS_DATANODE_MIN_SUPPORTED_NAMENODE_VERSION_KEY);
{code}
3. Duplicate.

> Document missing properties in hdfs-default.xml
> -----------------------------------------------
>
>                 Key: HDFS-8356
>                 URL: https://issues.apache.org/jira/browse/HDFS-8356
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability, test
>         Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch, 
> HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch, 
> HDFS-8356.006.patch, HDFS-8356.007.patch, HDFS-8356.008.patch, 
> HDFS-8356.009.patch, HDFS-8356.010.patch, HDFS-8356.011.patch, 
> HDFS-8356.012.patch
>
>
> The following properties are currently not defined in hdfs-default.xml. These 
> properties should either be
> A) documented in hdfs-default.xml OR
> B) listed as an exception (with comments, e.g. for internal use) in the 
> TestHdfsConfigFields unit test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)