[
https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213978#comment-15213978
]
Akira AJISAKA commented on HDFS-8356:
-------------------------------------
Thanks [~rchiang] for updating the patch! Finally I've reviewed all the
parameters. Some additional comments:
# In dfs.namenode.replication.pending.timeout-sec, would you document that the
timeout is 5 minutes if the value is set to 0 or negative value. Please see
PendingReplicationBlocks.java for the detail.
# In dfs.namenode.stale.datanode.minimum.interval, the parameter is used for
calculating the interval for marking datanode stale. The interval is calculated
by (dfs.namenode.stale.datanode.minimum.interval) * (dfs.heartbeat.interval)
sec. If the interval is larger than "dfs.namenode.stale.datanode.interval", the
calculated value is used for the interval. Please see
{{DatanodeManager#getStaleIntervalFromConf}} for the detail.
# "dfs.datanode.startup" is not supposed to be configured by users, so we can
remove it from hdfs-default.xml, as well as "dfs.namenode.startup".
# Would you remove "dfs.web.authentication.kerberos.keytab" and
"dfs.web.authentication.kerberos.principal" from the patch because they are
already documented?
# Would you add "dfs.web.ugi" to DeprecatedProperties.md instead of adding it
to hdfs-default.xml?
> Document missing properties in hdfs-default.xml
> -----------------------------------------------
>
> Key: HDFS-8356
> URL: https://issues.apache.org/jira/browse/HDFS-8356
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.7.0
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Labels: supportability, test
> Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch,
> HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch,
> HDFS-8356.006.patch, HDFS-8356.007.patch, HDFS-8356.008.patch,
> HDFS-8356.009.patch
>
>
> The following properties are currently not defined in hdfs-default.xml. These
> properties should either be
> A) documented in hdfs-default.xml OR
> B) listed as an exception (with comments, e.g. for internal use) in the
> TestHdfsConfigFields unit test
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
