[ 
https://issues.apache.org/jira/browse/HDFS-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249525#comment-15249525
 ] 

Takanobu Asanuma commented on HDFS-8057:
----------------------------------------

Some comments for test results:
* I think checkstyle warns are same as the current codes. After resolving this 
jira, it is good to clean checkstyles about BlockReader.
* The new findbug comes from changing the variable to public. This variable is 
used in {{TestBlockReaderFactory}}. I will use the refrection there.
* The failed unit tests which are in {{TestRetryCacheWithHA}} and 
{{TestNamenodeRetryCache}} may be affected by the first patch. I am 
investigating the causes.

> Move BlockReader implementation to the client implementation package
> --------------------------------------------------------------------
>
>                 Key: HDFS-8057
>                 URL: https://issues.apache.org/jira/browse/HDFS-8057
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Takanobu Asanuma
>         Attachments: HDFS-8057.1.patch
>
>
> BlockReaderLocal, RemoteBlockReader, etc should be moved to 
> org.apache.hadoop.hdfs.client.impl.  We may as well rename RemoteBlockReader 
> to BlockReaderRemote.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to