[
https://issues.apache.org/jira/browse/HDFS-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253008#comment-15253008
]
Tsz Wo Nicholas Sze commented on HDFS-8057:
-------------------------------------------
Thanks for the new patch.
- We should not change Apache_Hadoop_HDFS_2.6.0.xml, which is a generated file.
- Let's also move the tests (BlockReaderTestUtil, TestBlockReaderBase,
TestBlockReaderFactory, TestBlockReaderLocal, TestBlockReaderRemote,
TestBlockReaderRemote2, TestBlockReaderLocalLegacy) to client.impl in
hadoop-hdfs-project/hadoop-hdfs (not hadoop-hdfs-project/hadoop-hdfs-client).
- After moved the tests, we don't need to change the BlockReaderLocal methods
to public.
- We may get RemoteBlockReader2.LOG by
LoggerFactory.getLogger(BlockReaderRemote2.class) in
TestClientBlockVerification. Then we don't need to change
RemoteBlockReader2.LOG to public.
> Move BlockReader implementation to the client implementation package
> --------------------------------------------------------------------
>
> Key: HDFS-8057
> URL: https://issues.apache.org/jira/browse/HDFS-8057
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Takanobu Asanuma
> Attachments: HDFS-8057.1.patch, HDFS-8057.2.patch
>
>
> BlockReaderLocal, RemoteBlockReader, etc should be moved to
> org.apache.hadoop.hdfs.client.impl. We may as well rename RemoteBlockReader
> to BlockReaderRemote.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
