[ 
https://issues.apache.org/jira/browse/HDFS-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254545#comment-15254545
 ] 

Arpit Agarwal commented on HDFS-9943:
-------------------------------------

Thanks for the patch [~xiaobingo]. 
# reconfReplicationMultiplier - this function doesn't seem to be doing anything 
with the new Value. 
# getParamEffectiveVal - Let's rename this to getParameterEffectiveValue and 
please add javadoc.

We may be overusing 'volatile' as we make more configuration parameters 
reconfigurable. Can you check to see whether any of the newly reconfigurable 
values are consumed within existing locks? If so can we document that and have 
the reconfiguration of that property get the same lock?

> Support reconfiguring namenode replication confs
> ------------------------------------------------
>
>                 Key: HDFS-9943
>                 URL: https://issues.apache.org/jira/browse/HDFS-9943
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-9943-HDFS-9000.000.patch, 
> HDFS-9943-HDFS-9000.001.patch, HDFS-9943-HDFS-9000.002.patch, 
> HDFS-9943-HDFS-9000.003.patch
>
>
> The following confs should be re-configurable in runtime.
> - dfs.namenode.replication.work.multiplier.per.iteration
> - dfs.namenode.replication.interval
> - dfs.namenode.replication.max-streams
> - dfs.namenode.replication.max-streams-hard-limit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to