[
https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008610#comment-13008610
]
Hadoop QA commented on HDFS-1763:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474023/hdfs-1763-2.patch
against trunk revision 1083021.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 165 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274//console
This message is automatically generated.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of
> the equivalent DFSConfigKeys define, and a couple places where the default is
> defined multiple places (once in DFSConfigKeys and once elsewhere, though
> both have the same value). This is error-prone, and also a pain in that it
> prevents eclipse from easily showing you all the places where a particular
> config option is used. Let's replace all the uses of the hard-coded option
> strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
