[
https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008636#comment-13008636
]
Tsz Wo (Nicholas), SZE commented on HDFS-1763:
----------------------------------------------
Hi Eli, there are some compilation errors in [build
#274|https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274/console]. I
also saw it in my machine after svn update.
{noformat}
[exec] -compile-fault-inject:
[exec] [echo] Start weaving aspects in place
[exec] [iajc]
/grid/0/hudson/hudson-slave/workspace/PreCommit-HDFS-Build/trunk/src/test/aop/org/apache/hadoop/fs/TestFiRename.java:63
[error] DFSConfigKeys cannot be resolved
[exec] [iajc] CONF.setLong(DFSConfigKeys.DFS_BLOCK_SIZE_KEY, 1);
[exec] [iajc] ^^^^^^^^
[exec] [iajc]
[exec] [iajc] 1 error
[exec]
[exec] BUILD FAILED
{noformat}
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of
> the equivalent DFSConfigKeys define, and a couple places where the default is
> defined multiple places (once in DFSConfigKeys and once elsewhere, though
> both have the same value). This is error-prone, and also a pain in that it
> prevents eclipse from easily showing you all the places where a particular
> config option is used. Let's replace all the uses of the hard-coded option
> strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
