[
https://issues.apache.org/jira/browse/HDFS-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319411#comment-15319411
]
Hadoop QA commented on HDFS-10467:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 1s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 14 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
38s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 25s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 51s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 5s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 3s
{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 6m 50s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 6m 50s {color}
| {color:red} root generated 4 new + 695 unchanged - 2 fixed = 699 total (was
697) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 49s
{color} | {color:red} root: The patch generated 609 new + 1185 unchanged - 5
fixed = 1794 total (was 1190) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 49s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 12s
{color} | {color:red} The patch generated 4 new + 80 unchanged - 1 fixed = 84
total (was 81) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 48 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 2s
{color} | {color:red} The patch 37 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 56s
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 44 new + 0
unchanged - 0 fixed = 44 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 5s
{color} | {color:red} hadoop-hdfs-project_hadoop-hdfs generated 65 new + 7
unchanged - 0 fixed = 72 total (was 7) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m 15s
{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 50s {color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 30s
{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 145m 55s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
| | Unread field:StateStoreMetrics.java:[line 55] |
| | org.apache.hadoop.hdfs.server.federation.router.FederationConnectionId
doesn't override org.apache.hadoop.ipc.Client$ConnectionId.equals(Object) At
FederationConnectionId.java:At FederationConnectionId.java:[line 1] |
| |
org.apache.hadoop.hdfs.server.federation.router.FederationUtil.getJmx(String,
String) may fail to close stream At FederationUtil.java:close stream At
FederationUtil.java:[line 48] |
| | Should
org.apache.hadoop.hdfs.server.federation.router.NamenodeHearbeatService$NamenodeStatusReport
be a _static_ inner class? At NamenodeHearbeatService.java:inner class? At
NamenodeHearbeatService.java:[lines 91-141] |
| | Unread public/protected field:At NamenodeHearbeatService.java:[line 95] |
| |
org.apache.hadoop.hdfs.server.federation.router.Router.initAndStartRouter(Configuration,
boolean) invokes System.exit(...), which shuts down the entire virtual machine
At Router.java:shuts down the entire virtual machine At Router.java:[line
551] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hdfs.server.federation.router.Router.getConnection(MembershipStateEntity)
At Router.java:is not thrown in
org.apache.hadoop.hdfs.server.federation.router.Router.getConnection(MembershipStateEntity)
At Router.java:[line 931] |
| |
org.apache.hadoop.hdfs.server.federation.router.Router$CustomSocketFactory
doesn't override org.apache.hadoop.net.StandardSocketFactory.equals(Object) At
Router.java:At Router.java:[line 1] |
| | Should
org.apache.hadoop.hdfs.server.federation.router.Router$CustomSocketFactory be a
_static_ inner class? At Router.java:inner class? At Router.java:[lines
353-361] |
| | instanceof will always return false in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getListing(String,
byte[], boolean), since a RuntimeException can't be a java.io.IOException At
RouterRpcServer.java:in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getListing(String,
byte[], boolean), since a RuntimeException can't be a java.io.IOException At
RouterRpcServer.java:[line 794] |
| | Redundant nullcheck of connection, which is known to be non-null in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer$DefaultLookup.getClient()
Redundant null check at RouterRpcServer.java:is known to be non-null in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer$DefaultLookup.getClient()
Redundant null check at RouterRpcServer.java:[line 925] |
| | Write to static field
org.apache.hadoop.hdfs.server.federation.statestore.model.MembershipStateEntity._expirationMs
from instance method
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.init(Configuration)
At StateStore.java:from instance method
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.init(Configuration)
At StateStore.java:[line 164] |
| | Write to static field
org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity._expirationMs
from instance method
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.init(Configuration)
At StateStore.java:from instance method
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.init(Configuration)
At StateStore.java:[line 174] |
| | Write to static field
org.apache.hadoop.hdfs.server.federation.statestore.model.RouterEntity._expirationMs
from instance method
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.init(Configuration)
At StateStore.java:from instance method
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.init(Configuration)
At StateStore.java:[line 169] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.StateStore.overrideRegistration(String,
String, MembershipStateEntity$FederationNamenodeServiceState) does not release
lock on all exception paths At StateStore.java:release lock on all exception
paths At StateStore.java:[line 848] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.MountTableManager.getDestination(String)
does not release lock on all exception paths At MountTableManager.java:on all
exception paths At MountTableManager.java:[line 107] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.MountTableManager$MountTableTreeNode.toString(int)
concatenates strings using + in a loop At MountTableManager.java:in a loop
At MountTableManager.java:[line 331] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.deserializeObject(Object,
Class) invokes inefficient Boolean constructor; use Boolean.valueOf(...)
instead At StateStoreDriver.java:constructor; use Boolean.valueOf(...) instead
At StateStoreDriver.java:[line 411] |
| | Primitive boxed just to call toString in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.serializeObject(Object,
Class) At StateStoreDriver.java:toString in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.serializeObject(Object,
Class) At StateStoreDriver.java:[line 382] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.deserializeObject(Object,
Class) invokes inefficient new Integer(String) constructor; use
Integer.valueOf(String) instead At StateStoreDriver.java:Integer(String)
constructor; use Integer.valueOf(String) instead At
StateStoreDriver.java:[line 409] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.deserializeObject(Object,
Class) invokes inefficient new Long(String) constructor; use
Long.valueOf(String) instead At StateStoreDriver.java:Long(String)
constructor; use Long.valueOf(String) instead At StateStoreDriver.java:[line
407] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.serializeObject(Object,
Class) invokes inefficient new Long(long) constructor; use Long.valueOf(long)
instead At StateStoreDriver.java:Long(long) constructor; use
Long.valueOf(long) instead At StateStoreDriver.java:[line 382] |
| | Redundant nullcheck of results, which is known to be non-null in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.getSingle(Class,
Map) Redundant null check at StateStoreDriver.java:is known to be non-null in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.getSingle(Class,
Map) Redundant null check at StateStoreDriver.java:[line 204] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreDriver.filterMultiple(Map,
Iterable) makes inefficient use of keySet iterator instead of entrySet
iterator At StateStoreDriver.java:of keySet iterator instead of entrySet
iterator At StateStoreDriver.java:[line 120] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.readAllLinesFromFile(String):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.readAllLinesFromFile(String):
new java.io.FileReader(File) At StateStoreFile.java:[line 191] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.writeAll(Collection,
Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.writeAll(Collection,
Class): new java.io.FileWriter(File, boolean) At StateStoreFile.java:[line
276] |
| | Exceptional return value of java.io.File.createNewFile() ignored in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.init(Configuration,
StateStore) At StateStoreFile.java:ignored in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.init(Configuration,
StateStore) At StateStoreFile.java:[line 118] |
| | Exceptional return value of java.io.File.mkdirs() ignored in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.init(Configuration,
StateStore) At StateStoreFile.java:ignored in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.init(Configuration,
StateStore) At StateStoreFile.java:[line 106] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.getAll(Class)
does not release lock on all exception paths At StateStoreFile.java:on all
exception paths At StateStoreFile.java:[line 241] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFile.writeAll(Collection,
Class) does not release lock on all exception paths At
StateStoreFile.java:lock on all exception paths At StateStoreFile.java:[line
272] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getAll(Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getAll(Class):
new java.io.InputStreamReader(InputStream) At StateStoreFileSystem.java:[line
113] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.writeAll(Collection,
Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.writeAll(Collection,
Class): new java.io.OutputStreamWriter(OutputStream) At
StateStoreFileSystem.java:[line 163] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreFileSystem.getAll(Class)
may fail to close stream At StateStoreFileSystem.java:stream At
StateStoreFileSystem.java:[line 114] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.writeAll(Collection,
Class):in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.writeAll(Collection,
Class): String.getBytes() At StateStoreZooKeeper.java:[line 402] |
| | Inconsistent synchronization of
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.zkAuths;
locked 50% of time Unsynchronized access at StateStoreZooKeeper.java:50% of
time Unsynchronized access at StateStoreZooKeeper.java:[line 127] |
| | Inconsistent synchronization of
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper.zkHost;
locked 50% of time Unsynchronized access at StateStoreZooKeeper.java:50% of
time Unsynchronized access at StateStoreZooKeeper.java:[line 123] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper$ZKData.getData():in
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper$ZKData.getData():
new String(byte[]) At StateStoreZooKeeper.java:[line 285] |
| | Should
org.apache.hadoop.hdfs.server.federation.statestore.impl.StateStoreZooKeeper$ZKData
be a _static_ inner class? At StateStoreZooKeeper.java:inner class? At
StateStoreZooKeeper.java:[lines 280-285] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.serialize(StateStoreDriver)
At BaseEntity.java:is not thrown in
org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.serialize(StateStoreDriver)
At BaseEntity.java:[line 325] |
| |
org.apache.hadoop.hdfs.server.federation.statestore.model.BaseEntity.generateCacheKey(Map)
makes inefficient use of keySet iterator instead of entrySet iterator At
BaseEntity.java:keySet iterator instead of entrySet iterator At
BaseEntity.java:[line 179] |
| | Nullcheck of BaseEntity.dateModified at line 222 of value previously
dereferenced in
org.apache.hadoop.hdfs.server.federation.statestore.model.MembershipStateEntity.inflate(long)
At MembershipStateEntity.java:222 of value previously dereferenced in
org.apache.hadoop.hdfs.server.federation.statestore.model.MembershipStateEntity.inflate(long)
At MembershipStateEntity.java:[line 220] |
| | Invocation of toString on components in
org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
At MountTableEntity.java:in
org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
At MountTableEntity.java:[line 157] |
| | Invocation of toString on subComponents in
org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
At MountTableEntity.java:in
org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity.getLocations(String)
At MountTableEntity.java:[line 167] |
| | new
org.apache.hadoop.hdfs.server.federation.statestore.model.MountTableEntity(String,
Map) makes inefficient use of keySet iterator instead of entrySet iterator At
MountTableEntity.java:use of keySet iterator instead of entrySet iterator At
MountTableEntity.java:[line 80] |
| Failed junit tests | hadoop.hdfs.server.federation.statestore.TestMountTable |
| | hadoop.tools.TestHdfsConfigFields |
| | hadoop.hdfs.server.namenode.TestEditLog |
| | hadoop.hdfs.TestAsyncHDFSWithHA |
| Timed out junit tests |
org.apache.hadoop.hdfs.server.federation.router.TestRouterSafemode |
| | org.apache.hadoop.hdfs.server.federation.router.TestRouterJmx |
| | org.apache.hadoop.hdfs.server.federation.statestore.TestStateStore |
| | org.apache.hadoop.hdfs.server.federation.router.TestRouterAdmin |
| |
org.apache.hadoop.hdfs.server.federation.statestore.TestNamenodeRegistration |
| | org.apache.hadoop.hdfs.server.federation.router.TestRouterRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12808728/HDFS-10467.PoC.patch |
| JIRA Issue | HDFS-10467 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml shellcheck shelldocs cc |
| uname | Linux aef25500fe88 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / be34e85 |
| Default Java | 1.8.0_91 |
| shellcheck | v0.4.4 |
| findbugs | v3.0.0 |
| javac |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/diff-checkstyle-root.txt
|
| shellcheck |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/diff-patch-shellcheck.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/whitespace-tabs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/15692/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Router-based HDFS federation
> ----------------------------
>
> Key: HDFS-10467
> URL: https://issues.apache.org/jira/browse/HDFS-10467
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: fs
> Affects Versions: 2.7.2
> Reporter: Inigo Goiri
> Attachments: HDFS Router Federation.pdf, HDFS-10467.PoC.patch,
> HDFS-Router-Federation-Prototype.patch
>
>
> Add a Router to provide a federated view of multiple HDFS clusters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
