[
https://issues.apache.org/jira/browse/HDFS-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319470#comment-15319470
]
Rushabh S Shah commented on HDFS-10469:
---------------------------------------
Overall the patch looks good.
Just couple of comments.
1. In {{DataXceiverServer#closeAllPeers}}, I would set the metric to 0 since we
are closing all the data xceiver threads.
2. Since we have deprecated the key {{dfs.datanode.max.transfer.threads}} and
replaced the maxXceiverCount with hardcoded value of 4096, assigning
MutableGaugeInt to hold this metric (whose maximum value can be 4096) seems to
be wasteful.
Instead we can add MutableGaugeShort support.
I ran TestNameNodeMetadataConsistency and it didn't fail for me.
You need to address the checkstyle warnings.
> Add number of active xceivers to datanode metrics
> -------------------------------------------------
>
> Key: HDFS-10469
> URL: https://issues.apache.org/jira/browse/HDFS-10469
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0-alpha1
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Attachments: HDFS-10469.000.patch, HDFS-10469.001.patch
>
>
> Number of active xceivers is exposed via jmx, but not in Datanode metrics. We
> should add it to datanode metrics for monitoring the load on Datanodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
