[
https://issues.apache.org/jira/browse/HDFS-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340482#comment-15340482
]
Xiaoyu Yao commented on HDFS-10469:
-----------------------------------
Thanks [~hanishakoneru] for working on this. The patch looks good to me
overall. I just have a few questions:
1. If the goal is to capture the active xceiver thread count, we should not
incr the count in #DatanodeRunDatanodeDaemon() when we starts xceiverServer
thread. And the unit test logic around line 349 also needs to be updated.
{code}
@@ -2422,6 +2425,7 @@ public void runDatanodeDaemon() throws IOException {
if (localDataXceiverServer != null) {
localDataXceiverServer.start();
}
+ metrics.incrDataNodeActiveXceiversCount();
ipcServer.setTracer(tracer);
ipcServer.start();
startPlugins(conf);
{code}
2. NIT: To be consistent, the annotation string (Active DataNode Xceivers) does
not need to be capitalized.
{code}
@Metric("Count of Active DataNode Xceivers")
private MutableGaugeInt dataNodeActiveXceiversCount;
{code}
3. Unused code below in DataNodeMetrics.java can be removed.
{code}
public MutableGaugeInt getDataNodeActiveXceiversCount() {
return dataNodeActiveXceiversCount;
}
{code}
> Add number of active xceivers to datanode metrics
> -------------------------------------------------
>
> Key: HDFS-10469
> URL: https://issues.apache.org/jira/browse/HDFS-10469
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0-alpha1
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Attachments: HDFS-10469.000.patch, HDFS-10469.001.patch,
> HDFS-10469.002.patch
>
>
> Number of active xceivers is exposed via jmx, but not in Datanode metrics. We
> should add it to datanode metrics for monitoring the load on Datanodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
