[ 
https://issues.apache.org/jira/browse/HDFS-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330595#comment-15330595
 ] 

Jing Zhao commented on HDFS-10473:
----------------------------------

Thanks for updating the patch, Uma. And thanks for the review, Zhe.

Only updating {{validateAddBlock}} may not be enough. We also need to consider 
other scenarios such as the NameNode tries to choose extra datanodes to 
reconstruct EC blocks with missing internal blocks (i.e., 
{{ErasureCodingWork#chooseTargets}}). Maybe we can consider adding the extra 
check introduced in the current patch directly in 
{{INodeFile#getStoragePolicyID}}?

> Allow only suitable storage policies to be set on striped files
> ---------------------------------------------------------------
>
>                 Key: HDFS-10473
>                 URL: https://issues.apache.org/jira/browse/HDFS-10473
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-10473-01.patch, HDFS-10473-02.patch, 
> HDFS-10473-03.patch
>
>
> Currently some of existing storage policies are not suitable for striped 
> layout files.
> This JIRA proposes to reject setting storage policy on striped files.
> Another thought is to allow only suitable storage polices like ALL_SSD.
> Since the major use case of EC is for cold data, this may not be at high 
> importance. So, I am ok to reject setting storage policy on striped files at 
> this stage. Please suggest if others have some thoughts on this.
> Thanks [~zhz] for offline discussion on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to