[
https://issues.apache.org/jira/browse/HDFS-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343186#comment-15343186
]
Jing Zhao commented on HDFS-10473:
----------------------------------
Thanks for updating the patch, Uma. The latest patch looks pretty good to me.
One minor: it may be better to change the following log level to DEBUG,
considering the policy may be set on a high level directory and
{{getStoragePolicyID}} is widely called. +1 once this is addressed.
{code}
508 if (isStriped() && id != BLOCK_STORAGE_POLICY_ID_UNSPECIFIED
509 && !ErasureCodingPolicyManager
510 .checkStoragePolicySuitableForECStripedMode(id)) {
511 id = HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED;
512 LOG.warn("The current effective storage policy id : " + id
513 + " is not suitable for striped mode EC file : " + getName()
514 + ". So, just returning unspecified storage policy id");
515 }
{code}
> Allow only suitable storage policies to be set on striped files
> ---------------------------------------------------------------
>
> Key: HDFS-10473
> URL: https://issues.apache.org/jira/browse/HDFS-10473
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-10473-01.patch, HDFS-10473-02.patch,
> HDFS-10473-03.patch, HDFS-10473-04.patch
>
>
> Currently some of existing storage policies are not suitable for striped
> layout files.
> This JIRA proposes to reject setting storage policy on striped files.
> Another thought is to allow only suitable storage polices like ALL_SSD.
> Since the major use case of EC is for cold data, this may not be at high
> importance. So, I am ok to reject setting storage policy on striped files at
> this stage. Please suggest if others have some thoughts on this.
> Thanks [~zhz] for offline discussion on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
