[
https://issues.apache.org/jira/browse/HDFS-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339690#comment-15339690
]
James Clampffer commented on HDFS-10526:
----------------------------------------
Went through the rest of the code and ran some tests, everything looks good to
me.
Two things that would be kinda nice to have, but aren't close to being blockers:
-Comment above, a constant for timeouts, but I've already started going down
that path on the HA branch anyway so not worth adding at this point in my
opinion.
-ConnectComplete gets called twice when it's successful, once for the
connection callback, and once when ConnectComplete cancels the timer which in
turn calls ConnectComplete with an operation aborted error. The second error
is handled correctly; the only nit I have is the debug message says the
RpcConnection makes it look like this is a bad thing (ConnectComplete called
while not in connecting state). It's at the debug level so it's not going to
generate much noise.
I'd personally rather have the patch in it's current state as soon as possible
because it's solid and then then I can merge into HA and have that take
advantage of timeouts. +1
> libhdfs++: Add connect timeouts to async_connect calls
> ------------------------------------------------------
>
> Key: HDFS-10526
> URL: https://issues.apache.org/jira/browse/HDFS-10526
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-10526.HDFS-8707.000.patch,
> HDFS-10526.HDFS-8707.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
