[
https://issues.apache.org/jira/browse/HDFS-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363645#comment-15363645
]
Hadoop QA commented on HDFS-10600:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 4m
14s{color} | {color:red} Docker failed to build yetus/hadoop:9560f25. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12816360/HDFS-10600.001.patch |
| JIRA Issue | HDFS-10600 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/15988/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> PlanCommand#getThrsholdPercentage should not use throughput value.
> ------------------------------------------------------------------
>
> Key: HDFS-10600
> URL: https://issues.apache.org/jira/browse/HDFS-10600
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: diskbalancer
> Affects Versions: 2.9.0, 3.0.0-beta1
> Reporter: Lei (Eddy) Xu
> Assignee: Yiqun Lin
> Fix For: 2.9.0
>
> Attachments: HDFS-10600.001.patch
>
>
> In {{PlanCommand#getThresholdPercentage}}
> {code}
> private double getThresholdPercentage(CommandLine cmd) {
> ....
> if ((value <= 0.0) || (value > 100.0)) {
> value = getConf().getDouble(
> DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT,
> DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT_DEFAULT);
> }
> return value;
> }
> {code}
> {{DISK_THROUGHPUT}} has the unit of "MB", so it does not make sense to return
> {{throughput}} as a percentage value.
> Btw, we should use {{THROUGHPUT}} instead of {{THRUPUT}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
