[
https://issues.apache.org/jira/browse/HDFS-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377889#comment-15377889
]
Hudson commented on HDFS-10600:
-------------------------------
SUCCESS: Integrated in Hadoop-trunk-Commit #10100 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10100/])
HDFS-10600. PlanCommand#getThrsholdPercentage should not use throughput (lei:
rev 382dff74751b745de28a212df4897f525111d228)
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/PlanCommand.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DiskBalancer.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
> PlanCommand#getThrsholdPercentage should not use throughput value.
> ------------------------------------------------------------------
>
> Key: HDFS-10600
> URL: https://issues.apache.org/jira/browse/HDFS-10600
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: diskbalancer
> Affects Versions: 2.9.0, 3.0.0-beta1
> Reporter: Lei (Eddy) Xu
> Assignee: Yiqun Lin
> Fix For: 3.0.0-alpha1
>
> Attachments: HDFS-10600.001.patch, HDFS-10600.002.patch
>
>
> In {{PlanCommand#getThresholdPercentage}}
> {code}
> private double getThresholdPercentage(CommandLine cmd) {
> ....
> if ((value <= 0.0) || (value > 100.0)) {
> value = getConf().getDouble(
> DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT,
> DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT_DEFAULT);
> }
> return value;
> }
> {code}
> {{DISK_THROUGHPUT}} has the unit of "MB", so it does not make sense to return
> {{throughput}} as a percentage value.
> Btw, we should use {{THROUGHPUT}} instead of {{THRUPUT}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
