[
https://issues.apache.org/jira/browse/HDFS-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383139#comment-15383139
]
Akira Ajisaka commented on HDFS-10645:
--------------------------------------
+1 for the idea. Some comments from me:
1. Can we use Set<Integer> for blockReportSizes instead of int[]? That way we
can get the max value by just calling {{Collections.max}}. (and need to
synchronize the set)
2. Would you remove unused imports from TestDataNodeMXBean?
3. Would you remove the following unnecessarily comments from the test?
{code}
LOG.info("yuanbo print here " + dn.getBPServiceActorInfo());
{code}
Logging is good, but do not print your name in any source code.
> Make block report size as a metric and add this metric to datanode web ui
> -------------------------------------------------------------------------
>
> Key: HDFS-10645
> URL: https://issues.apache.org/jira/browse/HDFS-10645
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, ui
> Reporter: Yuanbo Liu
> Assignee: Yuanbo Liu
> Attachments: HDFS-10645.001.patch, Selection_047.png,
> Selection_048.png
>
>
> Record block report size as a metric and show it on datanode UI. It's
> important for administrators to know the bottleneck of block report, and the
> metric is also a good tuning metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
