[
https://issues.apache.org/jira/browse/HDFS-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388246#comment-15388246
]
Akira Ajisaka commented on HDFS-10645:
--------------------------------------
Thanks [~yuanbo] for the update! I'm thinking we're getting close. Some
comments:
# When setting {{maxDataLength}}, would you use {{dnConf}} instead of
{{dn.getConf()}}? Null check is not needed.
# {{maxDataLength}} should be final.
# After HDFS-10287, we can use try-with-resources statement for MiniDFSCluster.
Would you use the statement instead of shutting down the cluster in finally
clause?
# In Apache Hadoop, Jackson is commonly used for reading/writing json. Would
you use Jackson instead of Gson in the test code?
# Would you reverse the order of the arguments in the following assertion?
{code}
assertEquals("maxDataLength should be exactly "
+ "the same value of ipc.maximum.data.length",
maxDataLength,
confMaxDataLength);
{code}
Actual value is after expected value in Assert.assertEquals(message, expected,
actual).
> Make block report size as a metric and add this metric to datanode web ui
> -------------------------------------------------------------------------
>
> Key: HDFS-10645
> URL: https://issues.apache.org/jira/browse/HDFS-10645
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, ui
> Reporter: Yuanbo Liu
> Assignee: Yuanbo Liu
> Attachments: HDFS-10645.001.patch, HDFS-10645.002.patch,
> HDFS-10645.003.patch, HDFS-10645.004.patch, Selection_047.png,
> Selection_048.png
>
>
> Record block report size as a metric and show it on datanode UI. It's
> important for administrators to know the bottleneck of block report, and the
> metric is also a good tuning metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
