[
https://issues.apache.org/jira/browse/HDFS-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398904#comment-15398904
]
Akira Ajisaka commented on HDFS-10645:
--------------------------------------
Thank you for updating the patch, [~yuanbo]. Some comments.
{code}
@@ -113,6 +114,7 @@
<td>{reservedSpace|fmt_bytes}</td>
<td>{reservedSpaceForReplicas|fmt_bytes}</td>
<td>{numBlocks}</td>
+ <td>{maxBlockReportSize|fmt_bytes} ({maxDataLength|fmt_bytes})</td>
</tr>
{/dn.VolumeInfo}
</script>
{code}
1. The line is inserted wrongly. Would you insert the line as follows?
{code}
<td>{#helper_relative_time value="{LastBlockReport}"/}</td>
+ <td>{maxBlockReportSize|fmt_bytes} ({maxDataLength|fmt_bytes})</td>
</tr>
{code}
2. DNConf#maxDataLength() can be package private.
3. I don't think the following comment is necessary. This is obvious for me.
{code}
// get the value of maxDataLength.
this.maxDataLength = dnConf.getMaxDataLength();
{code}
> Make block report size as a metric and add this metric to datanode web ui
> -------------------------------------------------------------------------
>
> Key: HDFS-10645
> URL: https://issues.apache.org/jira/browse/HDFS-10645
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, ui
> Reporter: Yuanbo Liu
> Assignee: Yuanbo Liu
> Attachments: HDFS-10645.001.patch, HDFS-10645.002.patch,
> HDFS-10645.003.patch, HDFS-10645.004.patch, HDFS-10645.005.patch,
> Selection_047.png, Selection_048.png
>
>
> Record block report size as a metric and show it on datanode UI. It's
> important for administrators to know the bottleneck of block report, and the
> metric is also a good tuning metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
