[
https://issues.apache.org/jira/browse/HDFS-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391400#comment-15391400
]
John Zhuge commented on HDFS-10650:
-----------------------------------
Keep in mind, only when the callers pass in a null permission, this patch
changes default permission from 666 to 777 for directories. Check the call
hierarchy, do not see any issue. Potential problems are test code that expect
wrong dir permission when it passes null permission to mkdir, or scripts that
expect certain wrong default directory permissions. The second case is unlikely
while we can cover the first case by running all unit tests.
> DFSClient#mkdirs and DFSClient#primitiveMkdir should use default directory
> permission
> -------------------------------------------------------------------------------------
>
> Key: HDFS-10650
> URL: https://issues.apache.org/jira/browse/HDFS-10650
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HDFS-10650.001.patch, HDFS-10650.002.patch
>
>
> These 2 DFSClient methods should use default directory permission to create a
> directory.
> {code:java}
> public boolean mkdirs(String src, FsPermission permission,
> boolean createParent) throws IOException {
> if (permission == null) {
> permission = FsPermission.getDefault();
> }
> {code}
> {code:java}
> public boolean primitiveMkdir(String src, FsPermission absPermission,
> boolean createParent)
> throws IOException {
> checkOpen();
> if (absPermission == null) {
> absPermission =
> FsPermission.getDefault().applyUMask(dfsClientConf.uMask);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
