[ 
https://issues.apache.org/jira/browse/HDFS-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392670#comment-15392670
 ] 

Xiao Chen commented on HDFS-10650:
----------------------------------

Thanks for the comments, Chris and John. I think patch 2 is good.

Also went through places of {{applyUmask}} invocations, and the comments in 
HADOOP-9155, didn't see any problems. But this just feels like a huge change in 
behavior, so will let it sink for a couple of days.

Kicked a new jenkins run.

> DFSClient#mkdirs and DFSClient#primitiveMkdir should use default directory 
> permission
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-10650
>                 URL: https://issues.apache.org/jira/browse/HDFS-10650
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HDFS-10650.001.patch, HDFS-10650.002.patch
>
>
> These 2 DFSClient methods should use default directory permission to create a 
> directory.
> {code:java}
>   public boolean mkdirs(String src, FsPermission permission,
>       boolean createParent) throws IOException {
>     if (permission == null) {
>       permission = FsPermission.getDefault();
>     }
> {code}
> {code:java}
>   public boolean primitiveMkdir(String src, FsPermission absPermission, 
>     boolean createParent)
>     throws IOException {
>     checkOpen();
>     if (absPermission == null) {
>       absPermission = 
>         FsPermission.getDefault().applyUMask(dfsClientConf.uMask);
>     } 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to