[
https://issues.apache.org/jira/browse/HDFS-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399164#comment-15399164
]
Bob Hansen commented on HDFS-10672:
-----------------------------------
This is a better arrangement than what was in before, [~anatoli.shein]. Thanks.
In the C++ cat:
* The last_bytes_read parameter should be set to sizeof(buf) each time. That
makes this a very messy and error-prone API; buf_size and bytes_read should be
different parameters. Let's fix it as part of this bug.
* We need to fix ownership issues with the IOService. Filed HDFS-10704 to
capture that.
* We should have a no-args FileSystem::New. Filed HDFS-10705 to capture that.
* We should distinguish between normal end-of-file failures to read and "there
was an error" status. What should we expect when we get to EOF? We should
document that in the headers.
When the C cat was originally written, we didn't have configuration parsing in
libhdfs++. Now that we do, should we get rid of the URI stuff in the cat
examples and just check that they have a properly configured config directory
(with a nice message with how to set HADOOP_CONF_DIR if they don't)? I think
it will make this example much simpler and cleaner, if less useful (let's put
the useful one in the utility app).
> libhdfs++: reorder directories in src/main/libhdfspp/examples, and add C++
> version of cat tool
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-10672
> URL: https://issues.apache.org/jira/browse/HDFS-10672
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-10672.HDFS-8707.000.patch,
> HDFS-10672.HDFS-8707.001.patch
>
>
> src/main/libhdfspp/examples should be structured like
> examples/language/utility instead of examples/utility/language for easier
> access by different developers.
> Additionally implementing C++ version of cat tool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
