[ 
https://issues.apache.org/jira/browse/HDFS-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399383#comment-15399383
 ] 

Anatoli Shein commented on HDFS-10672:
--------------------------------------

Thank you for your commnets, [~bobhansen]. I have fixed the following issues in 
the new patch:

* The last_bytes_read parameter should be set to sizeof(buf) each time. That 
makes this a very messy and error-prone API; buf_size and bytes_read should be 
different parameters. Let's fix it as part of this bug.
(/) Done. Now PositionRead takes 4 parameters.

* We should distinguish between normal end-of-file failures to read and "there 
was an error" status. What should we expect when we get to EOF? We should 
document that in the headers.
(/) Done. I created a new error: invalid offset, which is set when trying to 
begin a read after the EOF, and documented this in the headers.

> libhdfs++: reorder directories in src/main/libhdfspp/examples, and add C++ 
> version of cat tool
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10672
>                 URL: https://issues.apache.org/jira/browse/HDFS-10672
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-10672.HDFS-8707.000.patch, 
> HDFS-10672.HDFS-8707.001.patch
>
>
> src/main/libhdfspp/examples should be structured like 
> examples/language/utility instead of examples/utility/language for easier 
> access by different developers.
> Additionally implementing C++ version of cat tool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to