[
https://issues.apache.org/jira/browse/HDFS-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407459#comment-15407459
]
Yuanbo Liu commented on HDFS-10694:
-----------------------------------
[~shv] Thanks for your comments.
1. Actually context is not a parameter of the private method {{processReport}},
see the code as below:
{code}
invalidatedBlocks = processReport(storageInfo, newReport,
context != null ? context.isSorted() : false, strBlockReportId);
{code}
context is used in ternary expression, so I keep this change in my patch.
2.
{quote}
Also did you miss "Processing first storage report ..."?
{quote}
It's printed by process log, not block blog. But it's good to print block id
here.
I uploaded v3 patch to address your comments, hope to get your thoughts. Thanks
again for your time.
> BlockManager.processReport() should print blockReportId in each log message.
> ----------------------------------------------------------------------------
>
> Key: HDFS-10694
> URL: https://issues.apache.org/jira/browse/HDFS-10694
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: logging, namenode
> Affects Versions: 2.6.1
> Reporter: Konstantin Shvachko
> Assignee: Yuanbo Liu
> Labels: newbie, supportability
> Attachments: HDFS-10694.001.patch, HDFS-10694.002.patch
>
>
> Currently {{BlockManager.processReport()}} is printing {{blockReportId}} in
> some log message, but doesn't in other. It should consistently print
> {{blockReportId}}. This is helpful in debugging block report problems, so
> that you could see which message belongs to which report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
