[
https://issues.apache.org/jira/browse/HDFS-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408903#comment-15408903
]
Konstantin Shvachko commented on HDFS-10694:
--------------------------------------------
# You are right there is no context in processReport(). So would it make sense
to replace two parameters ordered and reportId with one context? Then you can
get the former two inside processReport().
{{processReport(storageInfo, report, context) throws IOException}}
# Good that you noticed. For "first storage report" we should probably replace
{{LOG}} with {{blockLog}} to make it consistent with other messages.
Also could please use substitutions in the message rather than string
concatenation. People are trying to covert to sl4j style I was told.
> BlockManager.processReport() should print blockReportId in each log message.
> ----------------------------------------------------------------------------
>
> Key: HDFS-10694
> URL: https://issues.apache.org/jira/browse/HDFS-10694
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: logging, namenode
> Affects Versions: 2.6.1
> Reporter: Konstantin Shvachko
> Assignee: Yuanbo Liu
> Labels: newbie, supportability
> Attachments: HDFS-10694.001.patch, HDFS-10694.002.patch,
> HDFS-10694.003.patch
>
>
> Currently {{BlockManager.processReport()}} is printing {{blockReportId}} in
> some log message, but doesn't in other. It should consistently print
> {{blockReportId}}. This is helpful in debugging block report problems, so
> that you could see which message belongs to which report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
