[
https://issues.apache.org/jira/browse/HDFS-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417760#comment-15417760
]
Vrushali C commented on HDFS-10753:
-----------------------------------
Pasting a patch for this jira here:
{code}
diff --git
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java
index 35468da..a4ff2df 100644
---
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java
+++
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java
@@ -84,12 +84,12 @@ void addToCorruptReplicasMap(Block blk, DatanodeDescriptor
dn,
if (!nodes.keySet().contains(dn)) {
NameNode.blockStateChangeLog.debug(
"BLOCK NameSystem.addToCorruptReplicasMap: {} added as corrupt on "
- + "{} by {} {}", blk.getBlockName(), dn, Server.getRemoteIp(),
+ + "{} by {} {}", blk.toString(), dn, Server.getRemoteIp(),
reasonText);
} else {
NameNode.blockStateChangeLog.debug(
"BLOCK NameSystem.addToCorruptReplicasMap: duplicate requested for" +
- " {} to add as corrupt on {} by {} {}", blk.getBlockName(), dn,
+ " {} to add as corrupt on {} by {} {}", blk.toString(), dn,
Server.getRemoteIp(), reasonText);
}
// Add the node or update the reason.
{code}
> Method invocation in log can be replaced by variable because the variable's
> toString method contains more info
> --------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-10753
> URL: https://issues.apache.org/jira/browse/HDFS-10753
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.2
> Reporter: Nemo Chen
> Labels: easyfix, easytest
>
> Similar to the fix in HADOOP-6419, in file:
> hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java
> in line 76, the blk.getBlockName() method invocation is invoked on variable
> blk. "blk" is the class instance of Block.
> {code}
> void addToCorruptReplicasMap(Block blk, DatanodeDescriptor dn,
> String reason, Reason reasonCode) {
> ...
> NameNode.blockStateChangeLog.info(
> "BLOCK NameSystem.addToCorruptReplicasMap: {} added as corrupt on "
> + "{} by {} {}", blk.getBlockName(), dn, Server.getRemoteIp(),
> reasonText);
> {code}
> In file:
> hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/Block.java
> {code}
> @Override
> public String toString() {
> return getBlockName() + "_" + getGenerationStamp();
> }
> {code}
> The toString() method contain not only getBlockName() but also
> getGenerationStamp which may be helpful for debugging purpose. Therefore
> blk.getBlockName() can be replaced by blk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
