[
https://issues.apache.org/jira/browse/HDFS-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438635#comment-15438635
]
ASF GitHub Bot commented on HDFS-10753:
---------------------------------------
GitHub user albericliu opened a pull request:
https://github.com/apache/hadoop/pull/122
HDFS-10753.Method invocation in log can be replaced by variable becau…
…se the variable's toString method contains more info
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/albericliu/hadoop branch-2.7.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 6e46138c457d6eca0943271b3e3cfae26aae2536
Author: Liu Alberic <[email protected]>
Date: 2016-08-26T07:33:26Z
HDFS-10753.Method invocation in log can be replaced by variable because the
variable's toString method contains more info
----
> Method invocation in log can be replaced by variable because the variable's
> toString method contains more info
> --------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-10753
> URL: https://issues.apache.org/jira/browse/HDFS-10753
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.2
> Reporter: Nemo Chen
> Labels: easyfix, easytest
>
> Similar to the fix in HADOOP-6419, in file:
> hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java
> in line 76, the blk.getBlockName() method invocation is invoked on variable
> blk. "blk" is the class instance of Block.
> {code}
> void addToCorruptReplicasMap(Block blk, DatanodeDescriptor dn,
> String reason, Reason reasonCode) {
> ...
> NameNode.blockStateChangeLog.info(
> "BLOCK NameSystem.addToCorruptReplicasMap: {} added as corrupt on "
> + "{} by {} {}", blk.getBlockName(), dn, Server.getRemoteIp(),
> reasonText);
> {code}
> In file:
> hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/Block.java
> {code}
> @Override
> public String toString() {
> return getBlockName() + "_" + getGenerationStamp();
> }
> {code}
> The toString() method contain not only getBlockName() but also
> getGenerationStamp which may be helpful for debugging purpose. Therefore
> blk.getBlockName() can be replaced by blk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
