[
https://issues.apache.org/jira/browse/HDFS-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471196#comment-15471196
]
Anu Engineer commented on HDFS-10821:
-------------------------------------
[~linyiqun] Thank you for providing this patch. The changes look good, Some
small comments.
1. nit: Please remove "a" from this message.
{noformat}
Print out volume information for a DataNode(s)
{noformat}
2. Correct me if I am wrong, but nodeVal is a set of machines. so if you have
an invalid node, along with valid nodes, I think we are going to ignore the
invalid node silently.
{code}
List<DiskBalancerDataNode> dbdns = getNodes(nodeVal);
{code}
3. Could you please add a test case which passes an invalid node along with the
valid set and make sure that report command detects the invalid node correctly.
> DiskBalancer: Report command support with multiple nodes
> --------------------------------------------------------
>
> Key: HDFS-10821
> URL: https://issues.apache.org/jira/browse/HDFS-10821
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Fix For: 2.9.0
>
> Attachments: HDFS-10821.001.patch
>
>
> Since HDFS-10813 has committed to the trunk, then we can use {{getNodes}}
> method to parse the nodes string and support multiple nodes with {{hdfs
> diskbalancer}} subcommands(ex -report, -query). In this JIRA, we are focusing
> on the subcommand {{-report}}.
> That means we can use command {{hdfs diskbalancer -report -node}} to print
> one or one more datanodes report info. A test input command(here I use UUID
> to specify one datanode):
> {code}
> hdfs diskbalancer -report -node
> e05ade8e-fb28-42cf-9aa9-43e564c0ec99,38714337-84fb-4e35-9ea3-0bb47d6da700
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
