[
https://issues.apache.org/jira/browse/HDFS-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15476939#comment-15476939
]
Yiqun Lin commented on HDFS-10821:
----------------------------------
Thanks a lot for the quick review, [~anu].
{quote}
You might have to modify the getNodes function and return a list of invalid
nodes or throw an exception and abort the whole operation,
{quote}
I prefer to throw an exception and abort the whole operation here. And in the
future we can add a new option to ignore invalid nodes in input node string.
The new output from the test {{testReportCommandWithInvalidNode}}:
{code}
Processing report command
Reporting volume information for DataNode(s)
'bb6d51c1-7345-42dc-aaa3-122e16e12320,invalidNode'.
The node(s) 'invalidNode' not found. Please make sure that 'invalidNode' exists
in the cluster.
{code}
Attach a new patch, hope my latest patch can satisfy with you.
> DiskBalancer: Report command support with multiple nodes
> --------------------------------------------------------
>
> Key: HDFS-10821
> URL: https://issues.apache.org/jira/browse/HDFS-10821
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Fix For: 2.9.0
>
> Attachments: HDFS-10821.001.patch, HDFS-10821.002.patch,
> HDFS-10821.003.patch
>
>
> Since HDFS-10813 has committed to the trunk, then we can use {{getNodes}}
> method to parse the nodes string and support multiple nodes with {{hdfs
> diskbalancer}} subcommands(ex -report, -query). In this JIRA, we are focusing
> on the subcommand {{-report}}.
> That means we can use command {{hdfs diskbalancer -report -node}} to print
> one or one more datanodes report info. A test input command(here I use UUID
> to specify one datanode):
> {code}
> hdfs diskbalancer -report -node
> e05ade8e-fb28-42cf-9aa9-43e564c0ec99,38714337-84fb-4e35-9ea3-0bb47d6da700
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
