[ 
https://issues.apache.org/jira/browse/HDFS-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488521#comment-15488521
 ] 

Erik Krogen commented on HDFS-10713:
------------------------------------

One comment on this is that it would be ideal to change it to use 
{{o.a.h.util.Timer.monotonicNow()}} instead of {{Time.monotonicNow()}} to allow 
for the unit tests to complete quickly without real sleeps, especially now that 
we have a longer sleep for the reporting threshold. However I plan to do this 
as part of the work in progress in HDFS-10475 so I wouldn't worry about it 
here. 

Good work! Thanks for incorporating my read lock reporting changes into this 
throttling. 

> Throttle FsNameSystem lock warnings
> -----------------------------------
>
>                 Key: HDFS-10713
>                 URL: https://issues.apache.org/jira/browse/HDFS-10713
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: logging, namenode
>            Reporter: Arpit Agarwal
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-10713.000.patch, HDFS-10713.001.patch, 
> HDFS-10713.002.patch, HDFS-10713.003.patch, HDFS-10713.004.patch, 
> HDFS-10713.005.patch, HDFS-10713.006.patch
>
>
> The NameNode logs a message if the FSNamesystem write lock is held by a 
> thread for over 1 second. These messages can be throttled to at one most one 
> per x minutes to avoid potentially filling up NN logs. We can also log the 
> number of suppressed notices since the last log message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to