Arpit Agarwal commented on HDFS-10713:

Thanks for the updated patch Hanisha. longestReadLockHeldInterval needs its own 
do-while loop for atomic update (can be before the existing do-while loop).

Also the three test functions in FsNameSystem (setTimer, 
setTimeStampOfLastReadLockReport and setTimeStampOfLastWriteLockReport) can be 
package private.

LGTM otherwise.

> Throttle FsNameSystem lock warnings
> -----------------------------------
>                 Key: HDFS-10713
>                 URL: https://issues.apache.org/jira/browse/HDFS-10713
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: logging, namenode
>            Reporter: Arpit Agarwal
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-10713.000.patch, HDFS-10713.001.patch, 
> HDFS-10713.002.patch, HDFS-10713.003.patch, HDFS-10713.004.patch, 
> HDFS-10713.005.patch, HDFS-10713.006.patch, HDFS-10713.007.patch, 
> HDFS-10713.008.patch
> The NameNode logs a message if the FSNamesystem write lock is held by a 
> thread for over 1 second. These messages can be throttled to at one most one 
> per x minutes to avoid potentially filling up NN logs. We can also log the 
> number of suppressed notices since the last log message.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to