[
https://issues.apache.org/jira/browse/HDFS-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492463#comment-15492463
]
Xiao Chen commented on HDFS-10823:
----------------------------------
Thanks for the patch Andrew! I didn't find a better alternative, and think this
makes sense.
Some review comments so far, I will have a more thorough review.
- {{FileSystem#DirectoryEntries}}:
-- member variables could be final.
-- The new {{listStatus}} should {{return new DirectoryEntries(listing, token,
false);}}
-- How do you feel just calling this new {{listStatus}} sth like
{{listStatusBatch}}? This is more consistent with the webhdfs/httpfs params,
and removes the confusion for users on the method overload.
- {{WebHdfsFileSystem}}
-- seems we can remove the {{DirListingIterator}} there.
- {{HttpFSFileSystem}}
-- Maybe the helper methods can go to {{HttpFSUtils}}?
-- Maybe we could reorganize the code in {{listStatus}} to parse
{{remainingEntries}} first, then {{newToken}}, so that we don't need 2
duplicate comments.
- We'll need (a bunch of) documentation.
> Implement HttpFSFileSystem#listStatusIterator
> ---------------------------------------------
>
> Key: HDFS-10823
> URL: https://issues.apache.org/jira/browse/HDFS-10823
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: httpfs
> Affects Versions: 2.6.4
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: HDFS-10823.001.patch, HDFS-10823.002.patch,
> HDFS-10823.003.patch
>
>
> Let's expose the same functionality added in HDFS-10784 for WebHDFS in HttpFS
> too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
