[ https://issues.apache.org/jira/browse/HDFS-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495078#comment-15495078 ]
Xiao Chen commented on HDFS-10823: ---------------------------------- Thanks for the quick rev, Andrew. I think we're pretty close. Nits: - {{HttpFSFileSystem}} Sorry I wasn't clear in my previous comments. bq. I see we check null on remainingEntries but not on DirectoryListing or partialListing, is this intentional? I meant to ask this: do we need to check the case where json doesn't contain those elements, which could lead to NPE? bq. Suggest to add DirectoryListing as a predefined constant too, and use the constants. I meant to say, 'xxx too. And use the constants, including 'partialListing' and 'remainingEntries'. - {{BaseTestHttpFSWith}} missing break after line 994. (not from this patch though). - {{HttpFSServer}} line 335 I think we usually put this on a separate line. > Implement HttpFSFileSystem#listStatusIterator > --------------------------------------------- > > Key: HDFS-10823 > URL: https://issues.apache.org/jira/browse/HDFS-10823 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs > Affects Versions: 2.6.4 > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: HDFS-10823.001.patch, HDFS-10823.002.patch, > HDFS-10823.003.patch, HDFS-10823.004.patch, HDFS-10823.005.patch > > > Let's expose the same functionality added in HDFS-10784 for WebHDFS in HttpFS > too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org