[
https://issues.apache.org/jira/browse/HDFS-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511225#comment-15511225
]
Inigo Goiri commented on HDFS-10881:
------------------------------------
[~jakace], this is a good starting point for the rest of the patches.
A few comments:
* Can you fix the checkstyles? Basically, it's just adding the
package-info.java and adding periods to the javadocs.
* There are a bunch of javadocs warning (e.g.,
{{StateStoreDriver#getIdentifier}} and missing ones (e.g., {{BaseRecord}}).
* In {{FederationStateStoreService}} could you add the full comment of what the
State Store does (something like what you had in HDFS-10630 but without going
into particular implementation) and move the current class comment into the
internal TODO?
* Do we need the constructor in {{FederationStateStoreUtils}}?
* Across the code, you have entity and entry for the name of some variables;
can we make them just record? When we do entityType, it should be clazz to
follow the rest of the HDFS/YARN code.
* In {{StateStoreUnavailableException}}, can we make it {{serialVersionUID =
1L;}}?
* In the {{QueryResult}} constructor, don't break the line.
* In {{QueryResult}}, you have a typo in {{driverTimstamp}}.
> Federation State Store Driver API
> ---------------------------------
>
> Key: HDFS-10881
> URL: https://issues.apache.org/jira/browse/HDFS-10881
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs
> Reporter: Jason Kace
> Assignee: Jason Kace
> Attachments: HDFS-10881-HDFS-10467-001.patch,
> HDFS-10881-HDFS-10467-002.patch
>
>
> The API interfaces and minimal classes required to support a state store data
> backend such as ZooKeeper or a file system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
