[
https://issues.apache.org/jira/browse/HDFS-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555949#comment-15555949
]
Jing Zhao commented on HDFS-10827:
----------------------------------
Thanks for working on this, [~tasanuma0829]! The patch looks good to me
overall. Some minors:
# I think we can rename "isCorrupt" to "isMissing". In the outer "while" loop,
we're scanning all the blocks with {{QUEUE_WITH_CORRUPT_BLOCKS}} priority, and
this "if" logic is to select missing blocks.
# We may also want to take into account the decommissioning/decommissioned
internal blocks for the check.
# As follow-on work, maybe we can create a utility function to check if a block
is corrupted/missing, considering this is widely used in
BlockManager/FSNamesystem.
# For the unit test, do you think we can use {{MiniDFSCluster#corruptReplica}}
to simplify the code?
> When there are unrecoverable ec block groups, Namenode Web UI shows "There
> are X missing blocks." but doesn't show the block names.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-10827
> URL: https://issues.apache.org/jira/browse/HDFS-10827
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Attachments: HDFS-10827.1.patch, HDFS-10827.2.patch, case_2.png,
> case_3.png
>
>
> For RS-6-3, when there is one ec block group and
> 1) 0~3 out of 9 internal blocks are missing, NN Web UI doesn't show any warns.
> 2) 4~8 out of 9 internal blocks are missing, NN Web UI shows "There are 1
> missing blocks." but doesn't show the block names. (please see case_2.png)
> 3) 9 out of 9 internal blocks are missing, NN Web UI shows "There are 1
> missing blocks." and also shows the block name. (please see case_3.png)
> We should fix the case 2). I think NN Web UI should show the block names
> since the ec block group is unrecoverable.
> The values come from JMX. "There are X missing blocks." is
> {{NumberOfMissingBlocks}} and the block names are {{CorruptFiles}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
