[ 
https://issues.apache.org/jira/browse/HDFS-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568062#comment-15568062
 ] 

Takanobu Asanuma commented on HDFS-10827:
-----------------------------------------

Thank you for your kind review, [~jingzhao]!

On second thought, we may not need to check it, like below. Because the blocks 
in {{priorityQueues.get(QUEUE_WITH_CORRUPT_BLOCKS)}} is already took into 
account various cases in {{LowRedundancyBlocks.getPriority}}. What do you think?

{code:title=FSNameSystem.listCorruptFileBlocks|borderStyle=solid}
while (blkIterator.hasNext()) {
  BlockInfo blk = blkIterator.next();
  final INodeFile inode = getBlockCollection(blk);
  skip++;
  if (inode != null) {
    ...
  }
}
{code}

> When there are unrecoverable ec block groups, Namenode Web UI shows "There 
> are X missing blocks." but doesn't show the block names.
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10827
>                 URL: https://issues.apache.org/jira/browse/HDFS-10827
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>         Attachments: HDFS-10827.1.patch, HDFS-10827.2.patch, case_2.png, 
> case_3.png
>
>
> For RS-6-3, when there is one ec block group and
> 1) 0~3 out of 9 internal blocks are missing, NN Web UI doesn't show any warns.
> 2) 4~8 out of 9 internal blocks are missing, NN Web UI shows "There are 1 
> missing blocks." but doesn't show the block names. (please see case_2.png)
> 3) 9 out of 9 internal blocks are missing, NN Web UI shows "There are 1 
> missing blocks." and also shows the block name. (please see case_3.png)
> We should fix the case 2). I think NN Web UI should show the block names 
> since the ec block group is unrecoverable.
> The values come from JMX. "There are X missing blocks." is 
> {{NumberOfMissingBlocks}} and the block names are {{CorruptFiles}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to