[ https://issues.apache.org/jira/browse/HDFS-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585943#comment-15585943 ]
Erik Krogen commented on HDFS-11025: ------------------------------------ Agreed, shouldn't be necessary to keep the same port across the restarts. Thanks [~linyiqun] for catching and fixing this and [~ebadger] for taking a look. > TestDiskspaceQuotaUpdate fails in trunk > --------------------------------------- > > Key: HDFS-11025 > URL: https://issues.apache.org/jira/browse/HDFS-11025 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Priority: Minor > Attachments: HDFS-11025.001.patch > > > The test {{TestDiskspaceQuotaUpdate}} fails sometimes after HDFS-10843, the > link addresse: > https://builds.apache.org/job/PreCommit-HDFS-Build/17200/testReport/. The > stack infos: > {code} > java.net.BindException: Problem binding to [localhost:49195] > java.net.BindException: Address already in use; For more details see: > http://wiki.apache.org/hadoop/BindException > {code} > I found the bind exception was happened in new test method > {{TestDiskspaceQuotaUpdate.testQuotaIssuesWhileCommitting}}. The related > codes: > {code} > public void testQuotaIssuesWhileCommitting() throws Exception { > ... > try { > for (int i = REPLICATION - 1; i > 0; i--) { > dnprops.add(cluster.stopDataNode(i)); > } > ... > } finally { > for (MiniDFSCluster.DataNodeProperties dnprop : dnprops) { > cluster.restartDataNode(dnprop, true); > } > cluster.waitActive(); > } > } > {code} > I think we can make a simple fix in {{cluster.restartDataNode(dnprop, > true);}}. The tests in {{TestDiskspaceQuotaUpdate}} just care about that if > the cluster is up and running. So I think this change will not influence the > current logic, -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org