[
https://issues.apache.org/jira/browse/HDFS-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627666#comment-15627666
]
Uma Maheswara Rao G commented on HDFS-10954:
--------------------------------------------
Thank you [~rakeshr] for giving the patch, I have reviewed this patch. Please
check the comments below.
# -
{code}
+public class BlocksStorageMovementResult {
+
+ private final long trackId;
+ private final MovementStatus status;
{code}
Please change MovementStatus to Status
# -
for testPerTrackIdBlocksStorageMovementResults:
Can you check TestStorageReport for adding test case instead of adding temp
method for assertion if possible? If above test does not help, then fine.
# -
{code}
if (blksMovementResults != null) {
+ builder.addAllBlksMovementResults(
+ PBHelper.convertBlksMovResults(blksMovementResults));
+ }
{code}
Since the BlocksStorageMovementResultProto is repeated type, you may need to
send empty array instead of skipping when null? I think its not made as
optional right.
> [SPS]: Provide mechanism to send blocks movement result back to NN from
> coordinator DN
> --------------------------------------------------------------------------------------
>
> Key: HDFS-10954
> URL: https://issues.apache.org/jira/browse/HDFS-10954
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-10954-HDFS-10285-00.patch,
> HDFS-10954-HDFS-10285-01.patch, HDFS-10954-HDFS-10285-02.patch
>
>
> This jira is a follow-up task of HDFS-10884. As part of HDFS-10884 jira, it
> is providing a mechanism to collect all the success/failed block movement
> results at the {{co-ordinator datanode}} side. Now, the idea of this jira is
> to discuss an efficient way to report these success/failed block movement
> results to namenode, so that NN can take necessary action based on this
> information.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
