[ 
https://issues.apache.org/jira/browse/HDFS-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628656#comment-15628656
 ] 

Rakesh R commented on HDFS-10954:
---------------------------------

Thank you [~umamaheswararao] for the useful comments. Attached new patch fixing 
comments 1 & 3.

bq. Can you check TestStorageReport for adding test case instead of adding temp 
method for assertion if possible? If above test does not help, then fine.
I've gone through TestStorageReport  test case. There, I could see 
#sendHeartbeat is always sending reports with array of StorageReport objects. 
But in our case it will not be sending continuously and most of the time it 
will be an EMPTY_ARRAY. Also, we don't know when exactly the block storage 
movement will be completed and which #sendHeartbeat  RPC call carries the 
result. So I failed to find a consistent assertion and I skipped this 
comment(2nd comment).

> [SPS]: Provide mechanism to send blocks movement result back to NN from 
> coordinator DN
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-10954
>                 URL: https://issues.apache.org/jira/browse/HDFS-10954
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-10954-HDFS-10285-00.patch, 
> HDFS-10954-HDFS-10285-01.patch, HDFS-10954-HDFS-10285-02.patch, 
> HDFS-10954-HDFS-10285-03.patch
>
>
> This jira is a follow-up task of HDFS-10884. As part of HDFS-10884 jira, it 
> is providing a mechanism to collect all the success/failed block movement 
> results at the {{co-ordinator datanode}} side. Now, the idea of this jira is 
> to discuss an efficient way to report these success/failed block movement 
> results to namenode, so that NN can take necessary action based on this 
> information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to