[
https://issues.apache.org/jira/browse/HDFS-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637188#comment-15637188
]
Xiao Chen commented on HDFS-11045:
----------------------------------
Thanks [~templedf] for the continued effort on this!! The patch is getting big.
:)
A couple of comments:
- the modified {{DirectoryScanner#accumulateTimeRunning}} makes sense to me.
But found it a bit confusing at first glance. Suggest to add some comments to
make it easier to read.
- testThrottling could use extract the retries loop into a new function
- maybe +- 10% itself is too restrictive? How do you feel about changing that
to +-20% (i.e. min=0.8, max=1.2)?
- Didn't understand this comment in test:
{code}
// The scanner should sleep 500ms out of every 1sec. If we've slept at
// least 200ms, we've run for at least 1600ms.
{code}
> TestDirectoryScanner#testThrottling fails: Throttle is too permissive
> ---------------------------------------------------------------------
>
> Key: HDFS-11045
> URL: https://issues.apache.org/jira/browse/HDFS-11045
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 3.0.0-alpha2
> Reporter: John Zhuge
> Assignee: Daniel Templeton
> Priority: Minor
> Attachments: HDFS-11045.001.patch, HDFS-11045.002.patch,
> HDFS-11045.003.patch, HDFS-11045.004.patch, HDFS-11045.005.patch,
> HDFS-11045.006.patch, HDFS-11045.007.patch, HDFS-11045.008.patch
>
>
> TestDirectoryScanner.testThrottling:709 Throttle is too permissive
> https://builds.apache.org/job/PreCommit-HDFS-Build/17259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
