[ 
https://issues.apache.org/jira/browse/HDFS-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730089#comment-15730089
 ] 

Daniel Templeton commented on HDFS-11045:
-----------------------------------------

That locking issue really seems to be the bane of this test.  If I make the 
test flexible enough to accept the skewed values, then I'm not really testing 
anything anymore.  [~kasha] just pointed out an alternative I should have 
thought of a long time ago: don't actually run the scanner.  It looks like I 
should be able to easily take the {{ReportCompiler}} out of context and test it 
on its own.  I will still need a test that tests the real thing, but it just 
needs to test that throttling is happening and can be loose enough to take the 
locking issues in stride.

> TestDirectoryScanner#testThrottling fails: Throttle is too permissive
> ---------------------------------------------------------------------
>
>                 Key: HDFS-11045
>                 URL: https://issues.apache.org/jira/browse/HDFS-11045
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0-alpha2
>            Reporter: John Zhuge
>            Assignee: Daniel Templeton
>            Priority: Minor
>         Attachments: HDFS-11045.001.patch, HDFS-11045.002.patch, 
> HDFS-11045.003.patch, HDFS-11045.004.patch, HDFS-11045.005.patch, 
> HDFS-11045.006.patch, HDFS-11045.007.patch, HDFS-11045.008.patch, 
> HDFS-11045.009.patch
>
>
>   TestDirectoryScanner.testThrottling:709 Throttle is too permissive
> https://builds.apache.org/job/PreCommit-HDFS-Build/17259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to