[
https://issues.apache.org/jira/browse/HDFS-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651719#comment-15651719
]
Rakesh R commented on HDFS-10885:
---------------------------------
Thanks [~zhouwei] for the patch. Please take care below comments.
# Can we add a test case to verify StoragePolicySatisfier is getting stopped
due to Mover running. One idea is, you could first start NN by disabling SPS
and then start Mover process(may be you can simulate Mover existence by just
creating MOVER_ID_PATH path). Again restart NN by enabling SPS. I think, SPS
will log error message and shutdown himself. Test can assert by querying
{{#isStoragePolicySatisfierActive()}}
# Please add log to capture exception details.
{code}
+ } catch (IOException e) {
+ ret = false;
+ }
{code}
# Default values are different in hdfs-default.xml and DFSConfigs.java, can we
make this same.
{code}
+ public static final boolean DFS_NAMENODE_SPS_ENABLED_DEFAULT = true;
+ <name>dfs.namenode.sps.enabled</name>
+ <value>false</value>
{code}
# What if Mover sends RPC call to a Standby namenode. I think
{{nnrpc#isStoragePolicySatisfierActive()}} should throw StandbyException,
right?. Otw, Mover thinks that SPS is not running and can continue with his
startup by creating MOVER_ID path.
Also, we need to ensure SPS is started running only in Active NN. I'm OK to do
this task via separate jira if you feel so.
> [SPS]: Mover tool should not be allowed to run when Storage Policy Satisfier
> is on
> ----------------------------------------------------------------------------------
>
> Key: HDFS-10885
> URL: https://issues.apache.org/jira/browse/HDFS-10885
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-10285
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Fix For: HDFS-10285
>
> Attachments: HDFS-10800-HDFS-10885-00.patch,
> HDFS-10800-HDFS-10885-01.patch, HDFS-10800-HDFS-10885-02.patch,
> HDFS-10885-HDFS-10285.03.patch, HDFS-10885-HDFS-10285.04.patch,
> HDFS-10885-HDFS-10285.05.patch, HDFS-10885-HDFS-10285.06.patch,
> HDFS-10885-HDFS-10285.07.patch
>
>
> These two can not work at the same time to avoid conflicts and fight with
> each other.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
